fix: typescript default plugin file #20046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
ImCesar
changed the title
ImCesar
changed the title
ImCesar
changed the title
tbiethman
reviewed
Feb 4, 2022
| return cfg.pluginsFile ? cfg.pluginsFile : DEFAULT_PLUGIN_PATH | ||
| return cfg.pluginsFile ? cfg.pluginsFile : pluginPath | ||
| } catch { | ||
| return cfg.pluginsFile ? cfg.pluginsFile : path.normalize('cypress/plugins/index.js') |
There was a problem hiding this comment.
If cfg.pluginsFile is defined, can we return early?
if (cfg.pluginsFile) {
return cfg.pluginsFile
}
try {
let pluginPath = path.normalize('cypress/plugins/index.ts')
await fs.stat(path.join(root, pluginPath))
return pluginPath
} catch {
return path.normalize('cypress/plugins/index.js')
}
tbiethman
previously approved these changes
Feb 4, 2022
elevatebart
previously approved these changes
Feb 4, 2022
ImCesar
changed the title
ImCesar
changed the title
elevatebart
approved these changes
Feb 4, 2022
tgriesser
added a commit
that referenced
this pull request
Feb 7, 2022
* 10.0-release: chore: make error more informative about migration to Cypress 10 (#20007) fix: remove shelljs in example build script, correct file renames fix: last step in the ct setup goes back to start (#20030) fix: typescript default plugin file (#20046) chore: fix cypress npm package artifact upload path (#20023) chore(driver): move cy.within logic into it's own file (#20036) chore: update automerge workflows (#19982) fix(selectFile): use target window's File/DataTransfer classes (#20003) chore: Update Chrome (stable) to 98.0.4758.80 and Chrome (beta) to 98.0.4758.80 (#19995) fix: Adjust ffmpeg CLI args for performance (#19983) build: allow unified to run cypress on Apple Silicon (arm64) (backport #19067 to 9.x) (#19968) release 9.4.1 [skip ci] fix: trigger 9.4.1 build release 9.4.0 [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In typescript projects the default pluginFile can be an
index.tsfile. Currently we always assumed it was a js file and would not complete migration correctly.PR Tasks
cypress-documentation?type definitions?cypress.schema.json?